Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"marker-shape" is missing in the spec #23

Open
nyurik opened this issue Jun 18, 2016 · 1 comment
Open

"marker-shape" is missing in the spec #23

nyurik opened this issue Jun 18, 2016 · 1 comment

Comments

@nyurik
Copy link

nyurik commented Jun 18, 2016

It seems like "marker-shape": "pin" used to be a part the spec but was removed. Is there a reason not to allow customizable base?

@skeenp
Copy link

skeenp commented Jul 6, 2018

            // OPTIONAL: default "pin"
            // the shape of the marker icon
            // if not provided or "", no marker is underlaid
            // and only the symbol is shown
            // Allowed values include
            // - Icon ID
            "marker-shape": "pin",

The above would suffice. I too think this should be included in the spec. It would be good to allow implementations to optionally specify the marker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants