Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeoJSON: fix handling empty feature collections #4035

Open
artemp opened this issue Mar 12, 2019 · 1 comment · May be fixed by #4040
Open

GeoJSON: fix handling empty feature collections #4035

artemp opened this issue Mar 12, 2019 · 1 comment · May be fixed by #4040
Assignees
@artemp
Labels
bug input.geojson

Comments

@artemp
Copy link
Member

artemp commented Mar 12, 2019 

{"type":"FeatureCollection","features":[]}

Valid (empty FeatureCollection) GeoJSON above ^ currently results in an exception thrown while parsing.

/opt/mapnik/bin/mapnik-index /tmp/empty.geojson 
max tree depth:8
split ratio:0.55
processing '/tmp/empty.geojson' as GeoJSON
Invalid extent box2d(INVALID)

^ the 'Invalid extentreported is not very helpful here. Better option is to reportno features to indexor similar for an emptyFeatureCollection`
@artemp artemp self-assigned this Mar 12, 2019
@artemp artemp mentioned this issue Mar 12, 2019
Closed
@artemp
Copy link
Member Author

artemp commented Mar 12, 2019 •
edited

@four43 Some more background.
Current behaviour to throw on empty FeatureCollection is expected:
https://github.com/mapnik/mapnik/blob/master/test/unit/datasource/geojson.cpp#L103-L113
but I think this is an oversight. The fix can be straight forward but I need to ponder and test it doesn't break other things. Cheers.

artemp added a commit that referenced this issue Mar 25, 2019
@artemp
GeJSON - allow empty FeatureCollections (#4035)
0f73b8b
@artemp artemp linked a pull request Sep 24, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemp artemp

Labels
bug input.geojson
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GeoJSON - allow empty FeatureCollection mapnik/mapnik
1 participant
@artemp