Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Justification for removing bisection for computing KL-confidence regions #81

Open
jklaise opened this issue Aug 30, 2022 · 1 comment
Open

Comments

@jklaise
Copy link

jklaise commented Aug 30, 2022

Hi @marcotcr, whilst browsing the repo I noticed that you've removed the bisection part for computing the upper and lower confidence bounds: ff0924e.

The bisection is required to compute the KL-bounds (4) and (5) defined in the bandit paper so I'm a bit puzzled as to why you've removed it. The new behaviour is also not Hoeffding-bound based (3) but rather is equivalent to running bisection just once and then returning whatever is found (note - there is also no guarantee that the bound returned will satisfy the inequalities in (4) and (5) - in practice I think this will result in looser bounds).

@ishcha
Copy link

ishcha commented Nov 23, 2022

Based on my understanding, I agree with you, @jklaise. The bounds will be looser, but I guess that's the way to scale this method to a larger number of input features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants