Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variance arg in atlantis_tracer_survey_select #8

Open
pfrater opened this issue Jul 12, 2017 · 2 comments
Open

Variance arg in atlantis_tracer_survey_select #8

pfrater opened this issue Jul 12, 2017 · 2 comments

Comments

@pfrater
Copy link
Contributor

pfrater commented Jul 12, 2017

Just out of curiousity...when random noise is added to the survey data in the function atlantis_tracer_survey_select the sigma argument is squared to produce the err_variance object within the function on line132 (which is then used as the sd argument of rnorm). I'm just wondering why this term is squared as rnorm takes standard deviation (which is the square root of variance) as the argument for how much variation to introduce in the normal distribution.

Shouldn't the sigma argument either be input directly into rnorm? Or alternatively the user could be asked for variance and then take the sqrt of that and put into rnorm

@lentinj
Copy link
Contributor

lentinj commented Jul 12, 2017

Just me getting confused, I think. Feel free to push something to get rid of it.

@pfrater
Copy link
Contributor Author

pfrater commented Jul 13, 2017

Got it. Just wanted to make sure it wasn't something else before changing. See #9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants