Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exterminate Jade #428

Open
trezy opened this issue Oct 29, 2015 · 5 comments
Open

Exterminate Jade #428

trezy opened this issue Oct 29, 2015 · 5 comments
Labels

Comments

@trezy
Copy link
Member

trezy commented Oct 29, 2015

Personally, I hate writing Jade. It's hard for me to read and given that HTML isn't a particularly difficult language to write, I feel like Jade is unnecessary. It's just another step in our insanely long build process.

How would everybody else feel about removing Jade and moving to using plain old HTML and maybe Handlebars or Underscore templates?

NOTE: These are obviously personal opinions. If everyone else prefers Jade I won't be offended. 😄

/cc @jdaudier @peterblazejewicz @scott-w @paulfalgout

@jdaudier
Copy link
Contributor

I prefer Jade, but I can go with whatever the majority prefers. 🍶

@samccone
Copy link
Member

what would be the wins here? or just a rewrite to rewrite?

@trezy
Copy link
Member Author

trezy commented Oct 29, 2015

From what I can see:

  1. Removing one barrier to entry
  2. Removing a step from our super long build process
  3. Making implementation of the Marionette framework a bit easier

In response to my own points:

  1. Jade may not be that big of a barrier to entry. I don't like using it but it didn't seem terribly difficult to pick up.
  2. Removing Jade likely won't make a huge dent in our build process, though I do imagine that shortening our build process will require lots of little enhancements like this.
  3. Implementing Marionette site-wide doesn't necessarily make sense. I could see value in implementing it site-wide to keep consistency instead of just having some sections being Marionette views and others not. This is really an argument to be had in a ticket about implementing Marionette, though.

@trezy trezy added question and removed discussion labels Oct 29, 2015
@peterblazejewicz
Copy link
Member

what would be the wins here? or just a rewrite to rewrite?

I think the content is the king (built upon JS documentation), the build process should be saved as much as possible for content, not markup generation. The rest should be reserved for optimizing content/markup size.
If the site (or part) is switched to Mj (spa), the reserved build process can be used to generate JSON-DL schemas snippets for dynamic content (yes, for crawlers) or to provide static version of the content presented with dynamic views.
a digression: at work I use Emmet, the folks would throw things at me if I start using Jade (.NET world)

@scott-w
Copy link
Member

scott-w commented Oct 29, 2015

It could be worthwhile streamlining it. I'm not familiar with the site setup but I've noticed there's a handlebars template there too.

At a higher level, if we have a blessed way of writing Marionette, such as what template engine to prefer by default, then we'd be best writing the site to follow that, in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants