Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Constructor implemented incorrectly. #2

Open
usama54321 opened this issue Sep 5, 2018 · 0 comments
Open

Copy Constructor implemented incorrectly. #2

usama54321 opened this issue Sep 5, 2018 · 0 comments

Comments

@usama54321
Copy link

The copy constructor here is implemented incorrectly. This results in buggy behavior. The expected constructor should copy over the configuration of the previous object, as well as the BBR States. The problem occurs when the object is copied over, and the state pointer is set to NULL in the bbr machine.

TcpBbr::TcpBbr(const TcpBbr &sock) :

I have fixed it locally, but the solution is really hacky, thus no PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant