Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssetCompressHelper::url() does not add base name #345

Open
saeideng opened this issue Mar 8, 2020 · 2 comments
Open

AssetCompressHelper::url() does not add base name #345

saeideng opened this issue Mar 8, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@saeideng
Copy link

saeideng commented Mar 8, 2020

home page : http://localhost/sub_folder

$this->AssetCompress->url('css-combined.css');

What happened

returns

/assets/css/css-combined.v123.css

What you expected to happen

should be

/sub_folder/assets/css/css-combined.v123.css

version :

markstory/asset_compress 3.3.0
@saeideng
Copy link
Author

saeideng commented Mar 8, 2020

if this is expected only add a note to top of method
change that is not BC
I just want to know this will not change for avoid duplicating with bellow code

        $path = $this->AssetCompress->url($css);
        $path = $this->Url->build($path);

@markstory markstory added this to the 3.4.x milestone Mar 8, 2020
@markstory markstory self-assigned this Mar 8, 2020
@markstory
Copy link
Owner

It has been a while since I looked at this code. I will see if base paths have ever been included in asset paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants