Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: module-import-declaration #67

Closed
wants to merge 1 commit into from
Closed

fix: module-import-declaration #67

wants to merge 1 commit into from

Conversation

f1sh1918
Copy link
Contributor

added typescript, typescript config to create declaration file using tsc, added tsc to build process

this pr fixes #31 which causes issues by importing the library

@f1sh1918
module-import-declaration: added typescript, typescript config to cre…
c1d50ef 
…ate declaration file using tsc, added tsc to build process
@marouanekadiri
Copy link
Owner

Unfortunately, generating a type definition file will not solve the real issue which is properly declaring the components of this package.

@f1sh1918
Copy link
Contributor Author

f1sh1918 commented Oct 25, 2021 •
edited

for sure you can also declare them and not generate the declarations. i think both ways work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

warning import
2 participants
@f1sh1918 @marouanekadiri