Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Remove implicit field creation #1356

Open
sloria opened this issue Aug 20, 2019 · 4 comments
Open

RFC: Remove implicit field creation #1356

sloria opened this issue Aug 20, 2019 · 4 comments

Comments

@sloria
Copy link
Member

sloria commented Aug 20, 2019

Proposal: Remove Implicit/inferred field creation (fields and additional class Meta options).

At the very least, it's an unnecessary feature that adds complexity to the codebase. At worst, it interacts in weird ways with consuming libraries that autogenerate fields (see #923). The feature was added pre-1.0, when there were no ORM integration libs, as a poor man's ModelSerializer. At this point, though, I think we can remove it.

@sloria sloria added this to the 4.0 milestone Aug 20, 2019
@sloria sloria pinned this issue Aug 20, 2019
@MikeBadescu
Copy link

To clarify, do you still plan to keep the Schema class meta unknown?

    class Meta:
        unknown = INCLUDE

@sloria
Copy link
Member Author

sloria commented Sep 2, 2019

Yes, the unknown field API will remain the unchanged.

@MikeBadescu
Copy link

Thank you!

@sloria
Copy link
Member Author

sloria commented Mar 30, 2021

Let's consider this accepted for 4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants