Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVT-AV1-PSY --target-quality support? #837

Open
NZDivinity opened this issue May 10, 2024 · 1 comment
Open

SVT-AV1-PSY --target-quality support? #837

NZDivinity opened this issue May 10, 2024 · 1 comment

Comments

@NZDivinity
Copy link

NZDivinity commented May 10, 2024

Currently the --target-quality parameter for Av1an does not work with the PSY fork of SVT-AV1 - errors out.
--target-quality does work when it is used in conjunction with --probe-slow.

The same Av1an command (without probe slow) works fine with regular SVT-AV1.

Any chance this parameter could be supported by SVT-AV1-PSY?

Edit : My bad, was a bit quick posting this issue. see Trix's reply below with context on possible cause.

@trixoniisama
Copy link

You could have given some additional context since we've started to troubleshoot it on the AV1 discord server...

It is likely that SVT-AV1-PSY is not recognized as modern SVT-AV1 and as such outdated parameters are fed to the encoder which leads to crashes.

The usefulness of keeping compatibility with incredibly old SVT-AV1 versions isn't evident to me. I think that to avoid further issues like this in the future, it would be better to remove support for these ancient versions. It will avoid false positives with potential forks and newer version numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants