Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nextcloud 28: missing icon in sidebar #705

Open
pulsejet opened this issue Oct 17, 2023 · 1 comment
Open

Nextcloud 28: missing icon in sidebar #705

pulsejet opened this issue Oct 17, 2023 · 1 comment

Comments

@pulsejet
Copy link

There are a couple of changes to the sidebar with 28:

  1. Tabs can only be registered after DOMContentLoaded
  2. The icon needs to be passed as a raw svg (not data uri or class name)

Should be easy to do this and be backward compatible. Corresponding change in Memories: pulsejet/memories@2ea45cd
@matiasdelellis
Copy link
Owner

Hi Varun,
Thank you so much! I will fix it soon!. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matiasdelellis @pulsejet