modifying GTK3 example to use pygobject, and adding a simple example to demonstrate NavigationToolbar in GTK3 #1007
Conversation
…to demonstrate NavigationToolbar in GTK3
| @@ -5,6 +5,8 @@ | |||
| *~ | |||
| *$ | |||
| *.bak | |||
| .project | |||
| .pydevproject | |||
There was a problem hiding this comment.
are these necessary? Running the example doesn't appear to produce these files, I don't think.
There was a problem hiding this comment.
Neither necessary nor relevant--but entirely harmless, and presumably useful if a developer uses eclipse/pydev (which I do not).
There was a problem hiding this comment.
Exactly as efiring says: these files are neither necessary nor relevant but they are helpful for folks like me who use Pydev (Pydev creates a .project and .pydevproject file for each "project"). Sorry, I must admit that I'm still very much a newbie when it comes to pull requests; I had assumed that only my first commit (the GTK3 example code) would be part of the pull request, not my additions to .gitignore. But, a efiring says, these additions to .gitignore should be entirely harmless for folks who don't use PyDev and will be useful for those who do use PyDev.
There was a problem hiding this comment.
These files should be added to the .gitignore file rather than being part of the repository (otherwise, simply changing the interpreter used in the pydev project, as one may do to test different python versions with mpl, would trigger an unnecessary source change).
There was a problem hiding this comment.
Hi pelson. I could be wrong but I think I have added these files to. gitignore
modifying GTK3 example to use pygobject, and adding a simple example to demonstrate NavigationToolbar in GTK3
|
I think the net effect of the pull request is fine; the examples run, and nothing seems to have gotten changed that shouldn't have. For future pull requests, however, please use something closer to the procedure described in the matplotlib docs, http://matplotlib.sourceforge.net/devel/gitwash/index.html. Specifically, make a feature branch for your feature, and make the pull request be from that. Don't merge from upstream or anywhere else. I think the third commit in the present pull request simply makes the history more confusing. |
|
Cool, thanks loads for taking the time to review this pull request and merge my modifications. Also, thank you for pointing me to the relevant documentation - I'll make sure I do it correctly next time! Thanks loads. Jack |
Hi there,
Great work with matplotlib - it's such a joy to use.
I'm developing an app using GTK3 accessed using
pygobject(instead ofpygtk). Whilst learning how to usematplotlibwithpygobject, I updated theembedding_in_gtk3.pyexample and I also added a very simple example demonstrating the use of the NavigationToolbar within GTK3.(This is my first pull request. And I'm rather new to matplotlib and Python so forgive me if I've done this all wrong!)
Thanks,
Jack