Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test failing on master #1046

Closed
pelson opened this issue Jul 28, 2012 · 2 comments
Closed

test failing on master #1046

pelson opened this issue Jul 28, 2012 · 2 comments

Comments

@pelson
Copy link
Member

pelson commented Jul 28, 2012

I am getting a test failure on the test_axes module, namely on test_contour_hatching.

pelson@~/dev/matplotlib> python tests.py matplotlib.tests.test_axes:test_contour_hatching
FFF

I've not yet had a chance to look into this issue further.

@mdboom
Copy link
Member

mdboom commented Aug 3, 2012

The range of colors present in the test is wider (both lighter and darker) than in the baseline image.

git bisect traced it back to this change 44d7556, which certainly makes sense.

@efiring: Assuming you stand by that change and extended range of colors is to be expected, then I suggest we update the baseline images for this example (to make the tests pass again) and maybe add a changelog entry that the range of colors selected from a colormap is now more inclusive/correct etc.?

@efiring
Copy link
Member

efiring commented Aug 3, 2012

I am working on a related change to color mapping in contours, so I can take care of this at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants