FigureManagerQT used in new_figure_manager of Qt4Agg backend

[pmeier82-zz]

There seems to be a FigureManagerQTAgg defined in backend_qt4agg.py, just wondering why its not used.

ref

[pelson]

Sensible question. Seems like it is a typo and is redundant. An extension to this would be to question the purpose of NavigationToolbar2QTAgg.

[tacaswell]

I actually think this is a bug that they are not used in new_figure_manager_given_figure in backend_qt4agg.

[efiring]

No, I think that both NavigationToolbar2QTAgg and FigureManagerQTAgg should be deleted from backend_qt4agg.py. They are functionally identical to their non-Agg counterparts. Neither the toolbar nor the Manager needs to know how the canvas is being rendered (i.e., by Agg).

[efiring]

PR #2629 seems to work; give it a try.

[tacaswell]

I had assumed it was overriding something, but that seems to not be true (nor does it seem to ever be called). I will leave other comments on the PR