Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update six.py to version 1.2 #1261

Merged
merged 1 commit into from Sep 17, 2012
Merged

Update six.py to version 1.2 #1261

merged 1 commit into from Sep 17, 2012

Conversation

cgohlke
Copy link
Contributor

@cgohlke cgohlke commented Sep 16, 2012

@pelson
Copy link
Member

pelson commented Sep 17, 2012

Including this package at the top level is bad practice in my eyes. It is going to conflict with other people's installation of six. I can see why we want to package it with mpl, but was there a reason not to put it under a sub-package of matplotlib? matplotlib.compatibility.six for instance...

@mdboom
Copy link
Member

mdboom commented Sep 17, 2012

As per a longing-standing practice with dependencies in matplotlib, it is only installed if it isn't already there. It was not installed as a subpackage because that would require patching dateutil to use it as a subpackage instead of at the top-level, which is even more of a maintenance burden.

I have remained with this approach for 1.2.x because there are many (including at my institution) who depend on these dependencies being included. However, for a not-too-far-off release, we should really get pip automatic dependency downloading working better. This is in bug #1157.

mdboom added a commit that referenced this pull request Sep 17, 2012
Update six.py to version 1.2
@mdboom mdboom merged commit 1e72892 into matplotlib:master Sep 17, 2012
@pelson
Copy link
Member

pelson commented Sep 17, 2012

Thanks for a full response on that. I take your points and agree with your sentiments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants