fix drawing error of fancyarrow of simple style (v1.2.x) #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oo close. This addresses matplotlib#566. Initial patch submitted by Rolf Barinka.
|
Not sure why Travis failed. I'm running the tests on my machine. |
|
All green. Thanks @leejjoon. I'll leave this open for the rest of today, to give some of the others a chance to share their feelings, and to give me a chance to look at the code. It should be merged by the end of today. |
|
Ok, I gave the code a very quick glance and it looks fine. There are some PEP8 styling issues but I'd rather not nitpick at this stage. |
efiring
added a commit
that referenced
this pull request
Oct 7, 2012
fix drawing error of fancyarrow of simple style (v1.2.x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #1129 to v1.2.x. The original example is now a test.