Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIXME comment in transforms.py #1364

Closed
dmcdougall opened this issue Oct 11, 2012 · 4 comments · Fixed by #1367
Closed

FIXME comment in transforms.py #1364

dmcdougall opened this issue Oct 11, 2012 · 4 comments · Fixed by #1367

Comments

@dmcdougall
Copy link
Member

This was found when looking through #1351. The offending line is: https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/transforms.py#L477

Any ideas?
@WeatherGod
Copy link
Member

probably was a transcription error and those x's should be y's.

@dmcdougall
Copy link
Member Author

That seems most probable.

@dmcdougall dmcdougall mentioned this issue Oct 11, 2012
Merged
@WeatherGod
Copy link
Member

Closing this issue since merging #1367 didn't close.

(Protip: github has a feature where in the merge message for a PR, one can say "closes issue #1364", and it will close it automatically. This is why it is a good idea to have such a statement in the initial PR message so that it shows up automatically in the merge message.)

@dmcdougall
Copy link
Member Author

It has to be in the commit message for that to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo in transforms.py dmcdougall/matplotlib
2 participants
@WeatherGod @dmcdougall