PEP8 fixes on textpath.py #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -478,13 +484,13 @@ def _revalidate_path(self): | |||
|
|
|||
| """ | |||
| if self._invalid or \ | |||
|
On this file, I also have those warnings: textpath.py:253: W806 local variable 'glyph' is assigned to but never used |
| @@ -113,7 +113,8 @@ def get_text_width_height_descent(self, s, prop, ismath): | |||
|
|
|||
| def get_text_path(self, prop, s, ismath=False, usetex=False): | |||
| """ | |||
| convert text *s* to path (a tuple of vertices and codes for matplotlib.math.Path). | |||
| convert text *s* to path (a tuple of vertices and codes for | |||
| matplotlib.math.Path). | |||
There was a problem hiding this comment.
Can we slip in a quick fix to this docstring: 'matplotlib.math.Path' --> 'matplotlib.path.Path'
|
@NelleV Perhaps it would make sense to consolidate all of the imports at the top of the file, and organize them with standard library first, then external libraries (numpy), then mpl stuff. |
|
It's done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP8 fixes on the textpath module.
Thanks,
N