PEP8 fixes on quiver.py #1379
Merged
PEP8 fixes on quiver.py #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -541,7 +540,8 @@ def _make_verts(self, U, V): | |||
| # Calculate eps based on the extents of the plot | |||
| # so that we don't end up with roundoff error from | |||
| # adding a small number to a large. | |||
| angles, lengths = self._angles_lengths(U, V, | |||
| angles, lengths = self._angles_lengths( | |||
| U, V, | |||
| eps=np.abs(self.ax.dataLim.extents).max() * 0.001) | |||
There was a problem hiding this comment.
This is a little too far to the left in my opinion.
There was a problem hiding this comment.
Sorry about that... I was testing why pep8 (the program) was complaining on that line, and this is what it was asking me to do. I'm filing a bug report for that.
|
I give this a +1 once @efiring's and @WeatherGod's concerns have been settled. |
|
Looks like the test failure was just travis flaking on a numpy install. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP8 fixes on the module quiver.
Thanks,
N.