PEP8 fixes on hatch.py #1384
Merged
PEP8 fixes on hatch.py #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
looks good to me too. Quick question. This is milestoned for 1.2.0, but this PR (and others) are targeting master. Is that an oops or what? |
|
@WeatherGod Ideally they should be targeted for 1.2.x, but it doesn't matter. Once they're squashed to one commit it's easy to cherry-pick it. |
|
Ah, so I should probably cherry-pick the ones I merged today? Didn't mean |
|
Not at all. Anything you have merged into the master branch that is also milestoned for 1.2.x should also be cherry-picked into 1.2.x. |
|
@WeatherGod Think of the v1.2.x milestone as "If this is targeted for master, don't forget to cherry-pick it into 1.2.x" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP8 fixes on the module hatch.
Thanks,
N.