PEP8 fixes on _cm.py #1394
Merged
PEP8 fixes on _cm.py #1394
+351
−230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 28: lambda x: np.abs((3 * x - 1) / 2), | ||
| 29: lambda x: np.abs((3 * x - 2) / 2), | ||
| 28: lambda x: np.abs((3 * x - 1) / 2), | ||
| 29: lambda x: np.abs((3 * x - 2) / 2), |
There was a problem hiding this comment.
Is x always a nonzero integer? If so then, at present, this calculation rounds down on division by two. Since I am not sure what color(x) does, this concerns me a little. The line above, however, np.abs((3 * x - 1) / 2) is fine, since 3x-1 is always even.
There was a problem hiding this comment.
Note the "from future import division" at the top of the file. That means dividing by 2 gives a floating point result if necessary, so there is no rounding down.
There was a problem hiding this comment.
Awesome, I learned something new. Thanks.
|
If someone can explain L153 then this gets my +1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP8 fixes on the module _cm