Rebase of #1418 on v1.2.x

[jenshnielsen]

#1420 is not needed on v1.2.x. This is a bug only present on master introduced in 2f11dee

[dmcdougall]

This gets my +1. Perhaps this should go in before the rc3 cut. What do the other developers think?

[mdboom]

It seems a little convoluted -- maybe we should add a short comment about why it iterates through the keys and looks them up, rather than just iterating through the values.

[dmcdougall]

@mdboom Perhaps we don't even need to iterate through the keys at all!

[dmcdougall]

boxes = [cell.get_window_extent(renderer) for cell in self._cells.values()]

[jenshnielsen]

Yes that would indeed be simpler. I updated the pull request to iterate over the keys instead.

[dmcdougall]

I updated the pull request to iterate over the keys instead.

Do you mean the values?

This solution looks much neater. +1.

[jenshnielsen]

Sorry, yes of course

[dmcdougall]

Thanks to @mdboom's feedback, I'm confident this is the correct solution now. There's an rc3 cut scheduled for tomorrow. I will leave this open so it can get some visibility before the cut. If there are no gripes by tomorrow morning I think this is good to go.

[dmcdougall]

Mergifying!