JRE - Modified 'use' so that it will only warn if the requested backend ... #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd is different that what is currently set.
|
+1. Seems like a reasonable thing to do. |
| # Check if we've already set up a backend | ||
| if 'matplotlib.backends' in sys.modules: | ||
| if warn: | ||
| # Warn only if called with a different name | ||
| if (rcParams['backend'] != name) and warn: |
There was a problem hiding this comment.
Complete nit-pick: I would typically put the warn first - because it is as far simpler evaluation (is a boolean True or False vs get the value from the dictionary and compare the strings).
I do not expect you to make this change (it is so trivial and adds nothing to the PR), I just wanted to mention it for future consideration.
Thanks,
|
Nice fix to the problem. Thanks @jrevans 👍 . |
|
+1 good to go in my opinion. Can anyone think of anything else that needs to be added to this? If not, I think it's safe to push The Button. |
pelson
added a commit
that referenced
this pull request
Nov 5, 2012
JRE - Modified 'use' so that it will only warn if the requested backend is different that what is currently set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the 'use' function so that if it is repeatedly called, it will only give a warning if the requested backend is different from the current one.