Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce examples.directory rcParams to customize cbook.get_sample_data() lookup location #1478

Closed
sandrotosi opened this issue Nov 10, 2012 · 2 comments

Comments

@sandrotosi
Copy link
Contributor

Hello,
following Debian policies, we're shipping the 'sample_data' contents in /usr/share/matplotlib/sample_data/ but cbook.get_sample_data() looks up those files into the module directory.

I tried patching get_sample_data() to set root to the path above, but that caused all the examples using get_sample_data() to fail in generating the images during documentation build because at that time, /usr/share/matplotlib/sample_data/ is still not populate.

I've then decided to reintroduce examples.directory parameter: this way I'll be able to set the temporary path during build time, and the correct path once the package will be installed.

I'll start writing a patch right away, I'll post it here once ready.

Cheers,
Sandro

@sandrotosi
Copy link
Contributor Author

I've opened #1479 (it's the first time I file a pull request, hope I did it correctly ;))

@dmcdougall
Copy link
Member

Thanks @sandrotosi. I'll close this in favour of #1479.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants