change handling of legend labels which are None #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Travis build failure is a dud (timeout error while downloading PIL). It only occurred for the py2.7 test. Note that this PR is against master branch only. Shall we cherry-pick to v1.2.x branch? |
|
I think, it is worth a patch for 1.2.x branch. (I won't do this cherry-picking myself, because I'm not sure what's the best way to do it on github). |
|
The preferred method is to branch off of v1.2.x and patch the maintenance branch. Then when v1.2.x is merged into master the new changes will apply to master. @segasai Are you comfortable doing this? |
ghost
assigned
|
No worries. I'll merge this and cherry-pick it back to 1.2.x myself. |
mdboom
added a commit
that referenced
this pull request
Jan 16, 2013
change handling of legend labels which are None
mdboom
added a commit
that referenced
this pull request
Jan 16, 2013
change handling of legend labels which are None
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1610