implemented inverse transform for Mollweide axes #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. I'd want to check the numerical accuracy of forward -> inverse -> forward before merging, but I have no problems with this in principle. Good stuff @lpsinger! |
The new test functions test_mollweide_forward_inverse_closure and test_mollweide_inverse_forward_closure test that the forward->inverse and inverse->forward compositions are approximate identities.
… test The goal was to exercise the MollweideAxes.MollweideTransform and MollweideAxes.InvertedMollweideTransform classes. The ax.transData property does not make use of either of these classes; the ax.transProjection property does.
|
👍 |
dmcdougall
added a commit
that referenced
this pull request
Jan 4, 2013
implemented inverse transform for Mollweide axes
|
Could this be merged into the next release? |
It is already merged and on master, so yes, this will be in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an inverse transform to the class
matplotlib.projections.geo.MollweideAxes.