Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt close events don't cascade properly. #1676

Closed
mdboom opened this issue Jan 17, 2013 · 1 comment
Closed

Qt close events don't cascade properly. #1676

mdboom opened this issue Jan 17, 2013 · 1 comment

Comments

@mdboom
Copy link
Member

mdboom commented Jan 17, 2013

In #1498, @tacaswell noted:

One (possibly too late) concern is that this completely shadows the 
closeEvent behavior of QMainWindow. I think the sub-class's 
closeEvent should include the line QMainWindow.closeEvent(self,event) 
to make sure that things are properly cascaded up the inheritance chain.

We should probably fix that.
@tacaswell tacaswell mentioned this issue Jan 17, 2013
Merged
tacaswell pushed a commit to tacaswell/matplotlib that referenced this issue Jan 17, 2013
@tacaswell
added QtGui.QMainWindow.closeEvent() to make sure the close event
ee4feb3 
cascades up properly.

issue matplotlib#1676
@dmcdougall
Copy link
Member

Fixed in #1678.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdboom @dmcdougall