Fix compiler warnings #1725
Fix compiler warnings #1725
Conversation
|
I didn't target 1.2.x on purpose. These don't fix bugs, and I didn't want them in 1.2.x 'just in case' they broke something I didn't think about. |
| npy_PyFile_DupClose(py_file, fp); | ||
| if (npy_PyFile_DupClose(py_file, fp)) { | ||
| throw Py::RuntimeError("Error closing dupe file handle"); | ||
| } |
There was a problem hiding this comment.
All this block does is make use of the value npy_PyFile_DupClose returns.
|
debian sid, gcc 4.7.2, python 2.7.3 warnings on master https://gist.github.com/4683894 Warnings on this branch https://gist.github.com/4683594 |
| // matplotlib. This is here so that the compiler doesn't complain | ||
| // that it is unused. | ||
| extern "C" { | ||
| __attribute__((unused)) static void simple_capsule_dtor(void *ptr); |
There was a problem hiding this comment.
Personally, I have absolutely no idea what this does (black magic 😄). Could somebody who does give it the 👍 please?
There was a problem hiding this comment.
Seems fine, except I wish there were a cleaner way to hide this warning... Don't know what that would be.
|
Other than my lack of understanding which I have pointed out, I'd be happy enough to merge this. Your right about targetting |
|
Looks fine -- but I may have some further changes shortly for some more warnings I'm still getting on my platform. |
|
@mdboom Go for it! :) |
|
I'm not seeing the compiler warnings I was seeing before -- perhaps I hadn't enough coffee that day. I think this is good to merge... |
Some of the compiler warnings started to bug me, so I tried to fix them. They're usually harmless, but sometimes they are not, as I will explain.
Currently, these are the warnings that are thrown during a python2.7 build of matplotlib (
clangon a mac is used here)After this patch is applied, these are the warnings that are still left. The first four are due to a 'bug' in the python API; treating string literals as
char *rather thanconst char *. There is a patch upstream for it, but I'm not sure if it will be back-ported to python 2.7.4.The last bunch of
Tcl/Tkwarnings are because the compiler is being handed both a-cflag and a-framework T{cl,k}flag, which are meant solely for the compilation and linking steps, respectively. To fix them, one would need to separate out the compile and link steps, but I don't know how to do that withdistutils, and they only appear on the mac. Linux and windows compilers do not support the-frameworkflag.I have tested this patch and I get a successful build with both Apple's builds of gcc and clang. All the tests pass locally with python 2.7. It would be nice to have these tested with python3, and a linux flavour of compiler.
I also fixed a typo in a comment.