Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MEP10 - documentation improvements on set_xlabel and text of axes.py #1798

Closed
wants to merge 2 commits into from
Closed

MEP10 - documentation improvements on set_xlabel and text of axes.py #1798

wants to merge 2 commits into from

Conversation

NelleV
Copy link
Member

@NelleV NelleV commented Mar 1, 2013

Here is a small patch for MEP10 documentation improvements on set_xlabel, set_ylabel and text

Thanks,
N

mdboom
mdboom reviewed Mar 1, 2013
View reviewed changes
lib/matplotlib/axes.py

Other parameters
----------------
kwargs : `~matplotlib.text.Text` properties:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the trailing colon needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a typo. It is fixed.

@mdboom
Copy link
Member

mdboom commented Mar 1, 2013

Looks great!

@NelleV
Copy link
Member Author

NelleV commented Mar 4, 2013

I screwed up this PR (I coded in master). I'm going to close it, and recreate it from a new branch.

@NelleV NelleV closed this Mar 4, 2013
@NelleV NelleV mentioned this pull request Mar 4, 2013
Merged
@NelleV
Copy link
Member Author

NelleV commented Mar 4, 2013

See #1804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NelleV @mdboom