Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF - correct return type for Axes.get_title #1832

Merged
merged 1 commit into from Mar 17, 2013

Conversation

ajdawson
Copy link
Contributor

Return type of Axes.get_title was changed by mistake. This PR reverts to the previous MPL behaviour. Caused by #1644 and reported in #1714.

@mspacek
Copy link
Contributor

mspacek commented Mar 17, 2013

Ah, OK. I was worried that change was intentional, and we'd all have to start doing Axes.get_title().get_text() all the time 😃 Thanks for fixing this.

Just so I'm clear, Axes.set_title has always returned a matplotlib.text.Text instance?

@ajdawson
Copy link
Contributor Author

Just so I'm clear, Axes.set_title has always returned a matplotlib.text.Text instance?

I believe that is correct yes.

@mspacek
Copy link
Contributor

mspacek commented Mar 17, 2013

Tested. This fixes #1714. Can someone merge it?

efiring added a commit that referenced this pull request Mar 17, 2013
BF - correct return type for Axes.get_title
@efiring efiring merged commit 2b2fa46 into matplotlib:master Mar 17, 2013
@ajdawson ajdawson deleted the fix-get-title branch July 18, 2013 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants