Raise exception when user tries to use set_xlim or set_ylim on a geographic projection #1856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty simple, atomic change but may require some documentation if accepted. I've found that when teaching users about projections, many people expect to be able to change the projection limits (rotate the projection) by using
set_xlim()
andset_ylim()
. The functions work on projection axes:but don't actually do anything. I propose (with this PR) that these functions explicitly throw a
NotImplementedError
so it is obvious to the user that they are not actually changing anything by using the limit functions: