Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added rcParam for x and y margin #1908

Merged
merged 4 commits into from Apr 17, 2013
Merged

Conversation

tacaswell
Copy link
Member

Addresses issue #1766

I get 3 test failures on my machine related to matplotlib.tests.test_text.test_font_styles.test, but I also get the same failure on current master, so I at least don't make it worse.

@pelson
Copy link
Member

pelson commented Apr 16, 2013

👍 once there is an item in the what's new section.
Nice addition @tacaswell

@@ -21,6 +21,12 @@ revision, see the :ref:`github-stats`.

new in matplotlib-1.3
=====================
`axes.xmargin` and `axes.ymargin` added to rcParams
---------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these fonts on github are monospace, in which case, would you mind making the underlining >= the length of the line being underlined?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lengths look equal in my browser (and in emacs which I know is monospace)

pelson added a commit that referenced this pull request Apr 17, 2013
added rcParam for x and y margin
@pelson pelson merged commit 44e3790 into matplotlib:master Apr 17, 2013
@tacaswell tacaswell deleted the margins_rcParam branch April 17, 2013 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants