Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FigureCanvasMac.flush_events() raises NotImplementedError #197

Closed
ddale opened this issue Jun 20, 2011 · 7 comments
Closed

FigureCanvasMac.flush_events() raises NotImplementedError #197

ddale opened this issue Jun 20, 2011 · 7 comments

Comments

@ddale
Copy link
Contributor

ddale commented Jun 20, 2011

Original report at SourceForge, opened Thu Mar 10 10:39:14 2011

FigureCanvasMac seems like it should be a "backend with GUI", but it doesn't implement flush_events(). Seems like it should pass, if nothing else.

SourceForge History

  • On Fri Mar 25 18:54:33 2011, by pivanov314: assigned_to: 100
@dmcdougall
Copy link
Member

I'm not sure there's a Cocoa API for this:

http://www.cocoabuilder.com/archive/cocoa/149352-flushing-events.html
http://cocoadev.com/wiki/FlushAppEventQueue

It appears that event polling was phased out after OS 9. Perhaps a pass is the best option here.

@mdehoon
Copy link
Contributor

mdehoon commented Dec 12, 2012

Actually why is a flush_events method needed? It is not used in the matplotlib source code. Perhaps it is better to remove flush_events altogether?

@efiring
Copy link
Member

efiring commented Jul 22, 2013

@mdehoon, flush_events dates back to February, 2008 as part of the official API for gui backends, so even though we don't use it internally or in examples, we can't just rip it out. It appears to be carefully implemented in the other gui backends, and at least for them it seems to be a reasonable method to have available. Therefore I think that adding it to the macosx backend as a no-op (if indeed there is not equivalent functionality available) would be the simplest way to solve the problem and close this issue.

@mdehoon
Copy link
Contributor

mdehoon commented Jul 22, 2013

OK, I'll add it then. This can be done on MacOSX using NSView displayIfNeeded.
If somebody could please accept pull request #2233 , then I'll create a new pull request for flush_events.

@efiring
Copy link
Member

efiring commented Jul 23, 2013

On 2013/07/22 1:49 PM, mdehoon wrote:

If somebody could please accept pull request #2233
#2233 , then I'll
create a new pull request for flush_events.

Done.

@mdehoon
Copy link
Contributor

mdehoon commented Jul 23, 2013

@efiring Thanks. Pull request #2245 adds a flush_events method to the MacOSX backend.

@dmcdougall
Copy link
Member

Resolved by #2245.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants