Collection's contains method doesn't honour offset_position attribute #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
…int_in_path_collection
|
@ChrMa: Can you confirm the attached patch fixes your bug? |
|
Again - looks good but needs a small test. 👍 |
mdboom
added a commit
to mdboom/matplotlib
that referenced
this pull request
May 3, 2013
|
@mdboom: Thank you for the quick response. The fix is working perfectly. |
|
As for the test, you might want to add something like picker=1 to the hexbin call to avoid getting a UserWarning about picker being None. |
mdboom
added a commit
that referenced
this pull request
May 3, 2013
…_position Collection's contains method doesn't honour offset_position attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contains method of Collection objects doesn't honour the newly introduced _offset_position attribute, making it fail when _offset_position == "data".
I noticed this when trying to add a pick_event handler to a hexbin plot, which does not work properly with matplotlob 1.2.x