-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tox.ini #2060
Fix tox.ini #2060
Conversation
# The number of processes is hardcoded, because using too many causes the | ||
# Travis VM to run out of memory (since so many copies of inkscape and | ||
# ghostscript are running at the same time). | ||
- echo Testing using 8 processes | ||
- python ../matplotlib/tests.py -sv --processes=8 --process-timeout=300 | ||
- tox -- --processes=8 --process-timeout=300 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've lost an -sv
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tkf.
Looks good. I'd like to hold off on merging this until post 1.3.0rc, since now's probably not a good time to mess with a known-working CI setup. |
This needs a rebase before merging. It looks like that tight_bbox test failure is not indicative or problems here, nonetheless a rebase should trigger a re-test anyway. @tkf Would you be able to do that? |
@dmcdougall OK. I'll rebase. |
I rebased. Travis CI works except for Python 3.3. I don't know why it failed. |
Yes -- the 3.3 failure is odd. The output seems to just suddenly stop... |
I reran py33 and I have problems with distribute. I then remembered this branch was made before the new distribute patch was merged. @tkf Can you rebase this again so I can rerun the py33 travis job? |
I fetched your branch to do some testing myself. I just noticed that each of the test runs is not respecting the correct environment. Notice that @tkf Do you know how to make Travis respect the correct |
Oh it's only using python 2.7 to |
Ok, it looks like |
@dmcdougall You can use this option to use distribute instead of setuptools: http://tox.readthedocs.org/en/latest/config.html#confval-distribute=True|False |
@tkf Is this still a live PR? If so, it needs a re-base. |
Closing due to inactivity and the fact that we have striped tox out for just about every where else. |
This PR fixes tox.ini. I also suggest to use tox in Travis CI, to prevent from breaking it.