Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We don't actually support Numpy v1.4 #2152

Closed
dmcdougall opened this issue Jun 23, 2013 · 3 comments
Closed

We don't actually support Numpy v1.4 #2152

dmcdougall opened this issue Jun 23, 2013 · 3 comments
Milestone

Comments

@dmcdougall
Copy link
Member

See #1839 (comment).

Version 1.2 of matplotlib includes this line which imports a header file from numpy that lives in numpy/npy_3kcompat.h. Well it turns out this file doesn't exist in version 1.4 of numpy, which we officially support.

This file does exist (note no 404 error) in version 1.5, though.

This does raise an interesting point: literally nobody is using numpy version 1.4, otherwise we would have received a bunch of complaints about build errors.

Time to purge the conditionals checking for numpy version 1.4.

@dmcdougall
Copy link
Member Author

Related: #2092

@tacaswell
Copy link
Member

@dmcdougall Can you put any time into this in the near future?

@tacaswell
Copy link
Member

Closing this as the min version in __init__.py is 1.5 and as near as I can tell there are only three other numpy version conditionals in tho code, one checking >1.6, one checking >1.2 (PR to remove that one coming shortly), and in the install scripts (which extracts the min version from __init__.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants