Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add darken and lighten to colors #2159

Closed
dvreed77 opened this issue Jun 28, 2013 · 7 comments
Closed

Add darken and lighten to colors #2159

dvreed77 opened this issue Jun 28, 2013 · 7 comments
Milestone

Comments

@dvreed77
Copy link

I was looking for something to contribute and have implemented some simple code to take a color and darken or lighten it. I found having this very useful in many instances and I think others would to. Do you agree and/or have any pointers for contributing since this is my first time.

@mdboom
Copy link
Member

mdboom commented Jul 1, 2013

We're glad to have you! Maybe just file a pull request showing what you have in mind, and we can start the discussion from there, with the understanding that pull requests (even from those of us that have been here a while) may change many times before they're ready.

@pelson
Copy link
Member

pelson commented Jul 16, 2013

This sounds pretty cool. Did you manage to submit any code @dvreed77?

@dvreed77
Copy link
Author

I hope to soon, life got in the way a little bit and I want to make sure I do this right and not rush it.

On Jul 16, 2013, at 4:22, Phil Elson notifications@github.com wrote:

This sounds pretty cool. Did you manage to submit any code @dvreed77?


Reply to this email directly or view it on GitHub.

@tacaswell
Copy link
Member

@dvreed77 Did you ever get a chance to work on this?

@dvreed77
Copy link
Author

I'm sorry I didn't. I'll see if I can squeeze it in sometime soon!

On Fri, Jan 17, 2014 at 12:59 AM, Thomas A Caswell <notifications@github.com

wrote:

@dvreed77 https://github.com/dvreed77 Did you ever get a chance to work
on this?


Reply to this email directly or view it on GitHubhttps://github.com//issues/2159#issuecomment-32582069
.

@dvreed77
Copy link
Author

I just submitted a code review to the devel mailing list on this. Thanks
for kicking me in the pants a bit ;)

On Fri, Jan 17, 2014 at 12:59 AM, Thomas A Caswell <notifications@github.com

wrote:

@dvreed77 https://github.com/dvreed77 Did you ever get a chance to work
on this?


Reply to this email directly or view it on GitHubhttps://github.com//issues/2159#issuecomment-32582069
.

@tacaswell tacaswell mentioned this issue Jan 20, 2014
@tacaswell
Copy link
Member

Closing in favor of the open PR #2745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants