Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mollweide projection no longer shows horizontal gridlines #2299

Closed
lpsinger opened this issue Aug 15, 2013 · 2 comments · Fixed by #2306
Closed

Mollweide projection no longer shows horizontal gridlines #2299

lpsinger opened this issue Aug 15, 2013 · 2 comments · Fixed by #2306

Comments

@lpsinger
Copy link
Contributor

As of Matplotlib 1.3.0, the Mollweide projection no longer show horizontal gridlines.

With this test command:

python -c "from matplotlib import pyplot as plt; plt.subplot(111, projection='mollweide'); plt.grid(); plt.savefig('moll.png')"

with Matplotlib 1.3.0 on MacPorts on Mac OS X Mountain Lion, you get this:

moll

whereas on Matplotlib 1.1.1rc2 on Debian Wheezy, you get:

moll_old

@lpsinger
Copy link
Contributor Author

git bisect narrows the appearance of the bug to one of three commits:

There are only 'skip'ped commits left to test.
The first bad commit could be any of:
255f213cd9fc6f458e13bb28fc43e8cb636b2158
4c0f3f30f805f53f91f22f26212d366c59d2ae48
63a40e47578a5013c4e8806b072b35bb5793aa3d
We cannot bisect more!

lpsinger added a commit to lpsinger/matplotlib that referenced this issue Aug 17, 2013
The function _get_pixel_distance_along_axis does not work for geographic
axes, in which pixels that are outside of the map area cannot be
meaningfully transformed back to data coordinates. To be safe, let us
just return 0.0 unless we are on rectilinear axes.

Fixes matplotlib#2299.
lpsinger added a commit to lpsinger/matplotlib that referenced this issue Aug 17, 2013
lpsinger added a commit to lpsinger/matplotlib that referenced this issue Aug 22, 2013
The function _get_pixel_distance_along_axis does not work for geographic
axes, in which pixels that are outside of the map area cannot be
meaningfully transformed back to data coordinates. To be safe, let us
just return 0.0 unless we are on rectilinear axes.

Fixes matplotlib#2299.
lpsinger added a commit to lpsinger/matplotlib that referenced this issue Aug 22, 2013
@lpsinger
Copy link
Contributor Author

Looks like the earlier unit test failures were transient. They were probably unrelated to this PR. Would someone please review the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant