New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up of Qt namespace breaks PySides #2318
Comments
@tacaswell Am I missing something? 1f3d871 appears to not be a valid commit. |
@dmcdougall Sorry, I apparently fail at copy-paste. Updated the issue with the correct sha1 (f7bee43) |
Oops, sorry about that. Unfortunately, I don't have any experience at all with PySide. To be honest, I didn't even know what According to this, QStrings are also apparently a relic of PyQt4's API 1. For API 2, they're gone, replaced with Python strings. PySide uses only API 2. So we'll have to force the use of API 2. I would guess there's already some machinery in MPL to do that: I'll try installing PySide and see if I can fix things up in master. |
@mspacek Thanks. If no immediate solution can be implemented or you come across difficulties then let me know and those commits can be reverted. |
@mspacek There is also https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/backends/qt4_compat.py which smooths over most of the differences. This had been in the back of my head to check, but I never got to it. Sorry for not catching this before it got merged. |
As a note, reverting just those two commits breaks the menu functionality altogether. |
Sorry, still haven't gotten around to it. I should be able to tomorrow though. |
@tacaswell this is now fixed by #2328, and can be closed. |
00aae5f breaks some of the compatibility bindings.
PySides
does not exportpyqtSignature
orpyqtProperty
so importingmatplotlib
fails. There may be more issues, but after those two I gave up and started to revert commits until it worked again ;)By reverting both f7bee43 and 00aae5f I could get master to work with
PySides
again.@mspacek can you take a look at this? I probably won't be able to look at this in detail until next week.
The text was updated successfully, but these errors were encountered: