Ignore any non-ascii characters when reading font information. #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tried #2320, merged just a few hours ago? |
|
I am sure that the patch fixed the issue. What surprises me though is that the fix only went into the 1.3.x branch, and not master (I only checked master for a fix, and didn't find the ticket itself). |
|
No worries. Things from the maintenance branch are generally merged into master only on a daily basis. This fix was only a few hours old. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I seem to have some fonts locally that have broken font information. These contain non-ascii characters, and I wouldn't be surprised if these are not even all the same encoding.
Well, simply ignoring the characters seems to work nicely.