Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document API change in hist #2430

Merged
merged 1 commit into from Sep 18, 2013
Merged

Document API change in hist #2430

merged 1 commit into from Sep 18, 2013

Conversation

neggert
Copy link
Contributor

@neggert neggert commented Sep 17, 2013

Per discussion in #2293. I was having issues getting the documentation to compile (exception: cannot import name _string_to_bool), but I think this is simple enough that it should be okay.

This time at the correct branch.

@WeatherGod
Copy link
Member

That exception might be the result of the refactoring. A common oversight is that when doing "from foo import *" does not import anything starting with an underscore unless explicitly put into foo.__all__. I wonder if this might be the case here?

@neggert
Copy link
Contributor Author

neggert commented Sep 17, 2013

Looks like the function in question was moved around in #2182, but I don't think those changes are in v1.3.x.

@WeatherGod
Copy link
Member

Did you install matplotlib v1.3 prior to trying to build the docs? Unlike the tests, sphinx works off of the installed version of matplotlib rather than an in-place build of it.

@neggert
Copy link
Contributor Author

neggert commented Sep 17, 2013

Yes, I've tried it with both this branch (installed using setup.py develop) and 1.3.0 from Anaconda.

@mdboom
Copy link
Member

mdboom commented Sep 17, 2013

I don't think setup.py develop will work -- you need to install to a virtualenv that sphinx will pick up. I keep meaning to get the build_sphinx command working, but at present it doesn't.

@neggert
Copy link
Contributor Author

neggert commented Sep 17, 2013

Alright, I got it working. There was a .pth file hanging around pointing to the wrong version of matplotlib. The html looks fine.

mdboom added a commit that referenced this pull request Sep 18, 2013
Document API change in hist
@mdboom mdboom merged commit 4daa8ca into matplotlib:v1.3.x Sep 18, 2013
@neggert neggert deleted the hist_doc branch September 23, 2013 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants