Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve issue #2482 #2493

Closed
wants to merge 5 commits into from
Closed

Solve issue #2482 #2493

wants to merge 5 commits into from

Conversation

vlsd
Copy link
Contributor

@vlsd vlsd commented Oct 3, 2013

First commit changes the order of arguments in the call to ffmpeg. Now output options go with the output file instead of the input file. This avoids an issue with ffmpeg 2.x rejecting the call.

Second commit fixes a bug where xrange() was assumed (incorrectly) to be a generator. It is in fact some sort of lazy list, so it does not have the __next__() method generators have.The bug manifested itself when calling FuncAnimate() with a constant number of frames, like in examples/animation/basic_example.py.

Third commit adds a note in the INSTALL document about the incompatibility of the tight setting for bbox with generating movies using pipe writers, like ffmpeg.

@tacaswell
Copy link
Member

You might want to squash some of these commits.

@vlsd
Copy link
Contributor Author

vlsd commented Oct 3, 2013

Sorry I just falsely assumed github would create a patch upon pull
requests. Silly me.
On Oct 3, 2013 4:53 PM, "Thomas A Caswell" notifications@github.com wrote:

You might want to squash some of these commits.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2493#issuecomment-25661536
.

@@ -372,7 +372,11 @@ backend : %(backend)s
#savefig.facecolor : white # figure facecolor when saving
#savefig.edgecolor : white # figure edgecolor when saving
#savefig.format : png # png, ps, pdf, svg
#savefig.bbox : standard # 'tight' or 'standard'.
#savefig.bbox : standard # 'tight' or 'standard'. 'tight' is incompatible with
# pipe-based animation backends but will work with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

silly formatting thing, can you put the sentence about the incompatibility on a new line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. let me know if that's not what you meant

@tacaswell
Copy link
Member

@mdboom or @efiring Can you take a look at this one? I think it is ready to go, but am wary of the merge from master in the history.

@efiring
Copy link
Member

efiring commented Nov 24, 2013

@tacaswell, I think it needs to be rebased interactively to eliminate the merge commit. I would not merge it as-is.

@mdboom
Copy link
Member

mdboom commented Nov 25, 2013

I have no issues with the content -- but as @efiring said, we'll need to get the merge commit out.

@vlsd
Copy link
Contributor Author

vlsd commented Nov 25, 2013

Probably easiest if I just open a separate pull request on a new branch. Sorry for the mess.

@vlsd vlsd closed this Nov 25, 2013
@vlsd
Copy link
Contributor Author

vlsd commented Nov 25, 2013

Moved all changes to a new branch and sent Pull Request #2615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants