New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve issue #2482 #2493
Solve issue #2482 #2493
Conversation
You might want to squash some of these commits. |
Sorry I just falsely assumed github would create a patch upon pull
|
@@ -372,7 +372,11 @@ backend : %(backend)s | |||
#savefig.facecolor : white # figure facecolor when saving | |||
#savefig.edgecolor : white # figure edgecolor when saving | |||
#savefig.format : png # png, ps, pdf, svg | |||
#savefig.bbox : standard # 'tight' or 'standard'. | |||
#savefig.bbox : standard # 'tight' or 'standard'. 'tight' is incompatible with | |||
# pipe-based animation backends but will work with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
silly formatting thing, can you put the sentence about the incompatibility on a new line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. let me know if that's not what you meant
@tacaswell, I think it needs to be rebased interactively to eliminate the merge commit. I would not merge it as-is. |
I have no issues with the content -- but as @efiring said, we'll need to get the merge commit out. |
Probably easiest if I just open a separate pull request on a new branch. Sorry for the mess. |
Moved all changes to a new branch and sent Pull Request #2615 |
First commit changes the order of arguments in the call to
ffmpeg
. Now output options go with the output file instead of the input file. This avoids an issue withffmpeg 2.x
rejecting the call.Second commit fixes a bug where
xrange()
was assumed (incorrectly) to be a generator. It is in fact some sort of lazy list, so it does not have the__next__()
method generators have.The bug manifested itself when callingFuncAnimate()
with a constant number of frames, like inexamples/animation/basic_example.py
.Third commit adds a note in the
INSTALL
document about the incompatibility of thetight
setting forbbox
with generating movies using pipe writers, likeffmpeg
.