Classes in _transforms.h in global namespace

[ddale]

Original report at SourceForge, opened Wed Nov 14 10:53:52 2007

Hi,

The classes and functions defined in src/_transforms.h are in the global namespace and have fairly generic names (e.g. min, Value). I have encountered one link clash with another class Value when using matplotlib with an external library. Matplotlib linked but failed with a SEGV when it entered the wrong Value code from the other library (not surprisingly!).

I have confirmed this can be fixed by placing the
body of _transforms.h in a "namespace _nc {...}", then
adding "using namespace _nc;" in all src/*.cpp files that include "_transforms.h". Or namespaces could be introduced more cleanly than this.

Thanks for a great package.

AK

SourceForge Comments

On Thu Dec 6 10:54:18 2007, mdboom wrote:

Logged In: YES
user_id=119312
Originator: NO

Just a note -- the _transforms.h/_transforms.cpp stuff is going away in the next release (post 0.91). It still may be worth making your changes on a maintenance release of 0.91, however.

[pelson]

Closing. This was related to the pre vn1 transform code. (@mdboom was involved in this issue on SF)