Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedding_webagg example: Download button does not work #2606

Merged
merged 1 commit into from Nov 28, 2013

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Nov 21, 2013

If you ran the example (https://github.com/matplotlib/matplotlib/blob/master/examples/user_interfaces/embedding_webagg.py) the download button does not work.

(You can download the figure when you go to http://127.0.0.1:8080/download.png, it's just the button which does not work)

One related question:
Is there any chance to integrate the webagg backend with flask? If yes, a full working example would be nice (maybe an example using any webframework for serving the html would be helpful).

@mdboom
Copy link
Member

mdboom commented Nov 21, 2013

Attached is a fix for the download button problem. Can you confirm it works for you?

As for Flask, last I checked, it did not support WebSockets, so it's not really going to work with this.

@bmu
Copy link
Author

bmu commented Nov 21, 2013

The fix works, thanks.

I just played with the example and changed it so that it uses tornado templates.
(I could create a pull request, if it is worth)
I "integrated" it with flask with a FallbackHandler (see http://stackoverflow.com/questions/8143141/using-flask-and-tornado-together).
However I want to change the plot from within the site (as an example one could change the linestyle or something).
I think this would make the example more useful.

Do you have any tips how to do this?

pelson added a commit that referenced this pull request Nov 28, 2013
embedding_webagg example: Download button does not work
@pelson pelson merged commit 350320f into matplotlib:master Nov 28, 2013
@mdboom mdboom deleted the webagg/download branch August 7, 2014 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants