Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent streamplot grid size #2653

Closed
ajdawson opened this issue Dec 5, 2013 · 2 comments
Closed

Inconsistent streamplot grid size #2653

ajdawson opened this issue Dec 5, 2013 · 2 comments

Comments

@ajdawson
Copy link
Contributor

ajdawson commented Dec 5, 2013

The documentation for streamplot says:

When density = 1, the domain is divided into a 25x25 grid — density
linearly scales this grid. ... For different densities in each
direction, use [density_x, density_y].

However the implementation is different. When density is 1 then the grid appears to be 30x30 (see streamplot.py L313), but if density is (1, 1) it is 25x25. I assume this is an error? Any idea @tonysyu?

@tonysyu
Copy link
Contributor

tonysyu commented Dec 28, 2013

Sorry it took me so long to reply to this issue, but it slipped under the radar. You're completely right. Most likely, the original implementation used 25x25, and I (presumably) thought that 30x30 looked better for some particular test case, so I changed it for the scalar variant. Personally, I'm fine with either. If you make a PR, I'll give my 👍 to however you choose to make it consistent.

@ajdawson
Copy link
Contributor Author

@tonysyu - see #2700 for my fix

@efiring efiring closed this as completed in e8f035d Jan 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants