Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG : errorbar does not respect lines.linestyle rcparam #2738

Closed
wants to merge 1 commit into from

Conversation

tacaswell
Copy link
Member

changed default value of fmt from '-' -> ''

fixes issue #2366

Fix that does minimal amount of reverse compatible breakage.
I think the only scenario where this will be a problem are cases
where users have set a non-default value for lines.linestyle, but
do not want the lines drawn by errorbar to respect that. I think that
this use case is broken because lines.linestyle should be respected by
plotting functions which draw lines.

@tacaswell
Copy link
Member Author

Had this against master, changed my mind and put it against 1.3, and now I finished that I think it should be against master instead.

changed default value of `fmt` from '-' -> ''

fixes issue matplotlib#2366

Fix that does minimal amount of reverse compatible breakage.
I think the only scenario where this will be a problem are cases
where users have set a non-default value for `lines.linestyle`, but
do not want the lines drawn by `errorbar` to respect that.  I think that
this use case is broken because `lines.linestyle` should be respected by
plotting functions which draw lines.
@efiring
Copy link
Member

efiring commented May 3, 2014

This doesn't look right to me. First, I agree with @tacaswell that this should be a 1.4 change, not 1.3 (which might be futile anyway, if another 1.3.x never emerges). Second, the docstring needs to be changed to reflect the new behavior. To be consistent with mpl practice, I think it would be this:

  • fmt=None (default) do the default, which is passing "" to plot, hence using the line rc defaults
  • fmt='none' (case insensitive), don't plot the connecting lines (or markers)
  • otherwise pass fmt to plot as the usual third argument.

My suspicion is that the default (a connecting line, given the usual rcParams) is rarely what users will want; but correcting that is a bigger break with the past, and I'm not sure what the best default would be.

efiring added a commit to efiring/matplotlib that referenced this pull request Jun 1, 2014
@tacaswell tacaswell closed this Jun 2, 2014
@tacaswell tacaswell deleted the fix_errorbar_fmt_dflt branch June 2, 2014 12:19
efiring added a commit to efiring/matplotlib that referenced this pull request Jun 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants