handle NaN case nicely in _is_sorted #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `>=` comparison would cause a "RuntimeWarning: invalid value encountered in greater_equal". Here, `np.amin` propagates NaN values appropriately and doesn't cause the warning to throw.
|
Can you include a unit test that exercises the bug? |
|
I added a test case, but I'm not sure how best to catch the warning message. Does nose provide something that will fail the test if a RuntimeWarning is thrown? |
|
I think that test is find without catching the warning (it would be ideal, but it's tricky to get right, particularly if tests are run in parallel, since warnings depend on global state). Thanks for the contribution. Merging. |
mdboom
added a commit
that referenced
this pull request
Jan 27, 2014
handle NaN case nicely in _is_sorted
solvents
pushed a commit
to solvents/matplotlib
that referenced
this pull request
Apr 22, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
>=comparison would cause aHere,
np.aminpropagates NaN values appropriately,which results in a single (non-ufunc) comparison that doesn't trigger any warnings.