Fix line color handling #2761
Merged
Fix line color handling #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added failing test for issue matplotlib#2760
Fixes matplotlib#2760 Fixes miss-handling of color conversion logic introduced in edc48f0
| @@ -527,7 +527,7 @@ def draw(self, renderer): | |||
| self._set_gc_clip(gc) | |||
|
|
|||
| ln_color_rgba = self._get_rgba_ln_color() | |||
| gc.set_foreground(ln_color_rgba) | |||
| gc.set_foreground(ln_color_rgba, isRGBA=True) | |||
| gc.set_alpha(ln_color_rgba[3]) | |||
There was a problem hiding this comment.
_get_rgba_in_color() can return a None, so the indexing here would break.
There was a problem hiding this comment.
gah, just now noticed you changed _get_rgba_ln_color()
|
@tacaswell: Do you consider this ready to merge? |
|
I think this is ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jakevdp please confirm that this fixes your problem.
Sorry about this, I am very surprised this did not come up sooner.