Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no 1.2.2 out in the wild #2765

Closed
wants to merge 1 commit into from

Conversation

tomspur
Copy link
Contributor

@tomspur tomspur commented Jan 25, 2014

Probably matplotlib 1.2.1 was meant back then... Isn't it?

Probably matplotlib 1.2.1 was meant back then...
@WeatherGod
Copy link
Member

Git blame tells me that the one to put in those lines was @mdboom at commit
tomspur@ae31877.
I recall an oddity with this one as one usually do not update whats_new.rst
for bugfix releases. But the bug being fixed here happened to introduce a
new feature. I guess the question is if this bugfix actually came out for
1.2.1 or after and we just intended to release 1.2.2?

@mdboom
Copy link
Member

mdboom commented Jan 27, 2014

Yeah -- this was made on the 1.2.x branch and noted there, but there was never a 1.2.2 release. We should just move this to 1.3.2 at this point (though we might never have one of those either).

EDIT: My point being that this should not be listed under 1.2.1, because the change does not exist there.

@pelson
Copy link
Member

pelson commented Jan 27, 2014

Closing - based on @mdboom's comments, this is a job for the release manager to do when the release notes are finalized.

Thanks for submitting the PR @tomspur.

@pelson pelson closed this Jan 27, 2014
@tomspur tomspur deleted the correct_doc_version branch March 8, 2017 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants