BUG : instantiate fall-back writer #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes matplotlib#2651 If the a string is passed into save as `writer` the code tries to look up a writer with that name and create it. If a writer with that name is not in the registry, it is replaced with the name of the first writer that _is_ in the registry, but not an instance of that type.
tacaswell
added a commit
that referenced
this pull request
Apr 27, 2014
BUG : instantiate fall-back writer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2651
If the a string is passed into save as
writerthe code tries tolook up a writer with that name and create it. If a writer with that
name is not in the registry, it is replaced with the name of the first
writer that is in the registry, but not an instance of that type.